matrix-org / matrix-org/matrix-rust-sdk
[Media] Stop loading media attachments into memory
Open
Nobody has claimed this yet.
A-Media
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
One limitation of the current implementation is that the whole file to be uploaded will be loaded into memory. While this is not a big concern at the moment (given resources available on modern devices) it will most likely cause future iOS share extensions to crash as they are memory restricted.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the current media attachment upload implementation to find where the complete file is loaded into memory; the issue does not name a file or test. Done means uploads no longer require the whole attachment in memory and the approach avoids memory-related crashes in iOS share extensions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- mobile-dev, performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100