matrix-org / matrix-org/matrix-rust-sdk

Use PossiblyRedacted types from Ruma for MinimalStateEvent

Open
#1,405 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
2.3k
Forks
500
Avg merge
1d 16h
Merged PRs (30d)
106

Description

… once there are conversion helpers in Ruma for Original / Redacted to PossiblyRedacted content types. This should reduce the amount of helper code we need for `BaseRoomInfo` updates.

As part of this, we should make sure to abort message-sending in rooms with a redacted `m.room.encryption` event.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating MinimalStateEvent and BaseRoomInfo updates, then check whether Ruma provides the Original/Redacted-to-PossiblyRedacted conversion helpers described in the issue. Trace message sending for rooms with a redacted m.room.encryption event; done means the helper code is reduced and sending aborts in that case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.