matrix-org / matrix-org/matrix-rust-sdk
Should StateChanges::add_redaction have an event_id parameter
Open
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
Followup to #1275 and #1277: Should we refactor parts of `StateChanges` so we don't have to pass things that are already part of the other parameters, but wrapped in `Raw`?
Contributor guide
Research direction
Start by reading the StateChanges::add_redaction implementation and the context in issues #1275 and #1277. Determine whether event_id duplicates information already contained in the other parameters, then use the maintainers' decision to define the scope and completion criteria for any refactor.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100