matrix-org / matrix-org/matrix-rust-sdk
Integration tests for redaction failing
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
since 1a57170970d3f4fa354c40f2fd243abbf9315be6 the redaction integration tests fail - name_static almost every time on CI, the other has been observed outside of CI to fail, too:
test tests::redaction::test_redacting_name_static ... FAILED
test tests::redaction::test_redacting_name ... ok
failures:
---- tests::redaction::test_redacting_name stdout ----
thread 'tests::redaction::test_redacting_name' panicked at 'dispatch dropped without returning error', /home/ben/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.14.20/src/client/conn.rs:329:35
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
tests::redaction::test_redacting_name
test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 5.61s
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run the redaction integration tests, especially tests::redaction::test_redacting_name_static and tests::redaction::test_redacting_name, and inspect the change introduced by commit 1a57170970d3f4fa354c40f2fd243abbf9315be6. Use the reported hyper dispatch failure and CI behavior as starting points; done means both tests pass reliably in CI and outside CI.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100