matrix-org / matrix-org/matrix-rust-sdk-crypto-nodejs
bindings/crypto-nodejs: Take strings for user IDs, device IDs, and room IDs
Open
@Hywan is already working on this.
Since Jun 30, 2022.
- Dominant language
- Rust
- Stars
- 11
- Forks
- 23
- Avg merge
- 22h 12m
- Merged PRs (30d)
- 1
Description
otherwise we end up with a lot of useless object creation in the JS side. For example:
```
const roomMembers = await this.client.getRoomMembers(roomId);
const keysClaimReq = await this.machine.getMissingSessions(roomMembers.map(u => new UserId(u)));
```
we probably don't need these objects when it's clear they will be user IDs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.