matrix-org / matrix-org/matrix-rust-sdk-crypto-nodejs

Replace download-lib with per-platform packages which include a binary

Open
#113 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
11
Forks
23
Avg merge
22h 12m
Merged PRs (30d)
1

Description

The download-lib script is a custom bit of javascript which is annoying to maintain and causes fragility.

Instead, we should build per-platform npm packages which include the prebuilt binary.

See https://github.com/matrix-org/seshat/pull/184 where we've recently been doing similar work for seshat.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the custom download-lib JavaScript script and reviewing how it currently obtains the binary. Then study the similar per-platform package work in seshat PR 184. Done means the platform-specific npm packages contain the prebuilt binary and replace the fragile download-lib approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, rust
Domain
build-system, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.