matrix-org / matrix-org/matrix-rust-sdk-crypto-nodejs
"accepts own signatures" test is flaky
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 11
- Forks
- 23
- Avg merge
- 22h 12m
- Merged PRs (30d)
- 1
Description
Every now and then, the test "OlmMachine › verifyBackup › accepts own signatures" in tests/machine.test.js fails in CI, but only for Node 20. [Here's an example.](https://github.com/matrix-org/matrix-rust-sdk-crypto-nodejs/actions/runs/5730805540/job/15530372222?pr=9#step:8:49)
AFAICT the test awaits everything that it needs to, so something else must be going wrong here. This should be fixed not only to have reliable CI, but to see if this indicates is a real user-impacting issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the "OlmMachine › verifyBackup › accepts own signatures" test in tests/machine.test.js and reproduce the failure under Node 20 using the linked CI run as a reference. Trace the awaited operations and compare behavior across runs or Node versions. Done means the test is reliable in CI and any user-impacting cause identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js, rust
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100