matrix-org / matrix-org/matrix-python-common
Factor out `SrvResolver`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Sydent has an SrvResolver class here: https://github.com/matrix-org/sydent/blob/8331f94e1e22c72c84683c271142f3237c707a27/sydent/http/srvresolver.py#L104
Synapse [has one too](https://github.com/matrix-org/synapse/blob/0c3565da4cdbe53646ae0bc737900526a1d3df67/synapse/http/federation/srv_resolver.py#L98-L97) with an associated [test case](https://github.com/matrix-org/synapse/blob/4b965c862dc66c0da5d3240add70e9b5f0aa720b/tests/http/federation/test_srv_resolver.py#L30).
I couldn't see one in Sygnal.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare sydent/http/srvresolver.py with synapse/http/federation/srv_resolver.py and its test at tests/http/federation/test_srv_resolver.py. Determine how the resolver should be factored into matrix-python-common for Sygnal, then add the corresponding test coverage; done means Sygnal can use the shared resolver without its own duplicate implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100