matrix-org / matrix-org/matrix-python-common
Common function `_reject_invalid_json` in both Synapse and Sygnal
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Noting common function _reject_invalid_json in both synapse and sygnal
Originally posted by @H-Shay in https://github.com/matrix-org/matrix-python-common/issues/1#issuecomment-966597137
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating _reject_invalid_json in Synapse and Sygnal and comparing its implementations and callers. Determine how the common behavior could be shared, then verify that existing behavior remains covered by the relevant tests; done means the duplicated function is no longer maintained separately.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100