matrix-org / matrix-org/matrix-js-sdk

[React Native] Unterminated string constant in unhomoglyph/data.json

Open
#970 6 comments 0 reactions 0 assignees View on GitHub
Z-Upstream
Dominant language
TypeScript
Stars
2.2k
Forks
704
Avg merge
1d 20h
Merged PRs (30d)
40

Description

![image](https://user-images.githubusercontent.com/20155539/60366718-fc242880-99b1-11e9-9ff1-2f61d79df353.png)

I get this error when using matrix-js-sdk with React Native Expo and I try to **publish** the project. (I can run the project in Simulator without publishing)

### Expected behavior
Expo should successfully publish the app to the user's account.

### To Reproduce
1. Create a new Expo project with `expo init`.
2. `yarn add matrix-js-sdk`.
3. Follow steps in [this article](https://annie-elequin.proseful.com/using-the-matrix-js-sdk-work-with-expo) to get `matrix-js-sdk` working.
4. Start package manager with `expo start` and in another terminal, run `expo publish`.

### Environment
MacOS 10.14.5
iOS Simulator XR 12.1
Node 10.16.0
Expo CLI 2.21.1 (SDK 33)
Matrix JS SDK 2.0.1

### Other Notes
I tried removing line 159 (the original error line) from unhomoglyph/data.json, which didn't work, and subsequently removed every line after that - it ended up just changing the error line to the last line in the file (154 in the screenshot).

Contributor guide

Open the contributing guide

Research direction

Start with unhomoglyph/data.json and reproduce the failure with expo publish in a minimal Expo project using matrix-js-sdk. Check the reported line and the file's JSON/string validity; done means Expo publishes successfully without the unterminated-string error.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.