matrix-org / matrix-org/matrix-js-sdk

Make use of pre- and post-hooks for run scripts

Open
#773 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

T-Enhancement
Dominant language
TypeScript
Stars
2.2k
Forks
704
Avg merge
1d 20h
Merged PRs (30d)
40

Description

In order to get rid of some `&&` (which make it hard to read the run-scripts in GitHub), consider using [pre- and post-hooks](https://docs.npmjs.com/misc/scripts) for npm run-scripts.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the repository's npm run-script definitions and identify the commands that use chained && expressions. Replace the relevant chaining with npm pre- and post-hooks while preserving the existing order and behavior, then run the affected scripts to confirm they still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.