matrix-org / matrix-org/matrix-js-sdk
Timelinesupport is not inherited from client
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
It might just be the wording of the errormessage, but when you create an eventTimelineSet by hand, you have to set timelineSupport specifically in the options when creating, and not as the error message below would suggest, in the MatrixClient you supply to the function.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/models/event-timeline-set.ts lines 358-364 and compare the error wording with how an eventTimelineSet created by hand receives timelineSupport versus the MatrixClient supplied to it. Confirm whether the behavior or only the message is wrong, then update the relevant behavior or wording and verify the resulting error or inheritance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100