matrix-org / matrix-org/matrix-js-sdk
Check state key while parsing `m.call.member` state events.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
Currently we do not check `m.call.member` state event keys allowing users to have multiple events for one device.
This is not to spec.
We should check the key when parsing the state event here: https://github.com/matrix-org/matrix-js-sdk/blob/8ebf04ae94e3f97c8326b7be5bffc56e47655c0a/src/matrixrtc/CallMembership.ts#L45-L63
Comment with more details: https://github.com/matrix-org/matrix-js-sdk/pull/4262#discussion_r1649240390
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/matrixrtc/CallMembership.ts lines 45-63, where m.call.member state events are parsed, and review the linked pull-request discussion for the key requirements. The work is done when parsing checks the state event key so multiple events cannot represent one device and the behavior matches the spec.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100