matrix-org / matrix-org/matrix-js-sdk
MatrixRTCSessionManager logs a lot at error level
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
@dbkr added new code to MatrixRTCSessionManager in this commit: https://github.com/matrix-org/matrix-js-sdk/commit/6836720e1e1c2cb01d49d6e5fcfc01afc14834ca
https://github.com/matrix-org/matrix-js-sdk/blob/95baccfbc10c582ce909b4c8c72739ab76c0b248/src/matrixrtc/MatrixRTCSessionManager.ts#L102-L108
This keeps logging error messages. Obviously the event is processed, before the new room is known by the client.
This should be handled more gracefully, because it seams to be a "normal" situation.
And maybe it needs to be changed, so that the needed processing is done, after the room was created?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/matrixrtc/MatrixRTCSessionManager.ts around lines 102-108 and compare the referenced commit 6836720e. Trace how events are handled when the room is not yet known by the client, then inspect nearby tests or event-processing entry points. Done means normal event ordering no longer produces error-level logs and the required processing remains correct after room creation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100