matrix-org / matrix-org/matrix-js-sdk
`shouldDisambiguate` doesn't check user membership
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
I am not sure if this is intentional but it looks like the JS SDK will continue to disambiguate users with the same name even after some have left the room.
I don't see an obvious check that the membership is `"join"` or `"invite"` in either `shouldDisambiguate` or `updateDisplayNameCache`.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the TypeScript implementations of shouldDisambiguate and updateDisplayNameCache, then trace how room membership is represented for users who have left or been invited. Confirm whether only members with join or invite membership should be considered for duplicate-name disambiguation; done means the behavior is covered by the relevant SDK tests and departed users no longer affect it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100