matrix-org / matrix-org/matrix-js-sdk
Switch test environment to jsdom to use EventTarget
Open
Nobody has claimed this yet.
A-Testing
T-Task
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
We write our own EventTarget implementation in a couple of places (eg. https://github.com/matrix-org/matrix-js-sdk/blob/develop/spec/test-utils/webrtc.ts#L96) - we should investigate whether we can use EventTarget directly by switching the test environment to jsdom.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with spec/test-utils/webrtc.ts, especially the custom EventTarget implementation, and inspect the repository's current test environment configuration. Run the relevant tests before changing the environment; the work is done when jsdom provides a usable EventTarget and the duplicated implementations can be replaced without regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100