matrix-org / matrix-org/matrix-js-sdk
PushProcessor appears to be applying `DEFAULT_OVERRIDE_RULES` overzealously
Open
Nobody has claimed this yet.
Help Wanted
T-Defect
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
See https://github.com/matrix-org/matrix-js-sdk/pull/2376
See https://github.com/vector-im/element-web/issues/15439
Simply removing the rule meant the UI was fed a correct value. The server knew about the value, but the PushProcessor or similar layer decided to overrule what the server was saying for that push rule.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the PushProcessor handling of DEFAULT_OVERRIDE_RULES, then review pull request 2376 and Element issue 15439 for the reported behavior. Trace why the server-provided push-rule value is overridden and verify that the UI receives the server value without removing valid rules.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100