matrix-org / matrix-org/matrix-js-sdk
Types: Register guest requires opts even though they seem to be not required
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
**Describe the bug**
https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/client.ts#L6900 defines opts as a mandatory arg while after that making it optional as well as having body optional.
This leads to `An argument for 'opts' was not provided.` with typescript.
**Expected behavior**
`opts` probably should have been marked as optional?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/client.ts around line 6900 and inspect the register guest method signature, especially the opts and body parameters. Verify the TypeScript call that omits opts, then confirm the signature accepts that usage without producing the reported missing-argument error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100