matrix-org / matrix-org/matrix-js-sdk
Maybe enable `prefer-nullish-coalescing` and `prefer-optional-chain`
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
https://typescript-eslint.io/rules/prefer-nullish-coalescing/
https://typescript-eslint.io/rules/prefer-optional-chain/
These discourage falsy/truthy checking, and actually check for undefined or null.
This'd help if a parameter is number | null/idx?: number, to not branch on 0.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the two referenced typescript-eslint rule pages and locate the repository's lint configuration and current lint command. Enable prefer-nullish-coalescing and prefer-optional-chain, then address the resulting violations and confirm the lint checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100