matrix-org / matrix-org/matrix-js-sdk
Enable `no-throw-literal`
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
https://typescript-eslint.io/rules/no-throw-literal
A lot of code seems to depend on the fact that any thrown error is at least some form of Error, so this'd help remove the possibility for undefined bugs.
We'll probably also want to add the option "allowThrowingAny": false
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the no-throw-literal rule documentation at the linked URL, then locate the repository's TypeScript ESLint configuration and review the resulting violations. Done means the rule is enabled with allowThrowingAny set to false and the affected throw sites are addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100