matrix-org / matrix-org/matrix-js-sdk
createMessagesRequest is not implementing "to" token
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
**Describe the bug**
The [createMessagesRequest](https://github.com/matrix-org/matrix-js-sdk/blob/a69d9a9f20b680e3710e0f43cca68a2ce31ba030/src/client.ts#L4678) method is not implementing a `to` parameter as described in the client server api doc [here](https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-rooms-roomid-messages).
**Expected behavior**
The SDK should implement the `to` parameter for room message requests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/client.ts at createMessagesRequest, then compare its request parameters with the linked Matrix client-server API documentation. Implement the documented to parameter for room message requests and verify the generated request matches the API contract.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100