matrix-org / matrix-org/matrix-js-sdk
Kill off legacy to_device ciphertext field `sender_device`
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
Which we already sometimes omit, and never ever read.
https://github.com/matrix-org/matrix-js-sdk/blob/d50e559f97a3d3a6420b4e6c60fbca7a9b3e85b1/src/crypto/olmlib.ts#L100-L101
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing src/crypto/olmlib.ts at the referenced lines and trace how the to_device ciphertext is constructed. Done means the legacy sender_device field is no longer included while existing encryption behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cryptography
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100