matrix-org / matrix-org/matrix-js-sdk
Translations not supported
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.2k
- Forks
- 704
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 40
Description
In particular, in Riot web the room name says "Empty room (was ..." when the other user leaves. This string can't be localized so it looks bad when everything else is in another language.
Related code: https://github.com/matrix-org/matrix-js-sdk/blob/84637c6ebd442346623bce562b441e1093d40270/src/models/room.js#L1910
Same issue with memberNamesToRoomName function, it always sets the room name to "{user1} and {user2}" for a room with 3 participants regardless of the current locale.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/models/room.js around line 1910 and inspect the memberNamesToRoomName function. Trace how Riot web supplies the current locale and identify how both the empty-room text and three-participant room names are produced. Done means these room names can be localized consistently with the rest of the interface.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- internationalization, localization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100