matrix-org / matrix-org/matrix-ios-sdk
Race condition on usersToCommit
Open
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 484
- Forks
- 225
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I'm getting a race condition here.
Please use a serial queue for setting a user in this array:
```swift
- (void)storeUser:(MXUser *)user
{
[super storeUser:user];
usersToCommit[user.userId] = user;
}
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate storeUser: and inspect the existing accesses to usersToCommit, including how the surrounding SDK code handles concurrency. Ensure setting the user is serialized as requested and verify that usersToCommit updates no longer race with other accesses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100