matrix-org / matrix-org/matrix-ios-sdk
replaceTag in swift doesn't actually replace the tag
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 484
- Forks
- 225
- PR merge metrics
- No merged PRs in 30d
Description
This is the current implementation:
```
@nonobjc @discardableResult func replaceTag(_ oldTag: String, with newTag: String?, withOrder newTagOrder: String, completion: @escaping (_ response: MXResponse) -> Void) -> MXHTTPOperation {
return __addTag(oldTag, withOrder: newTagOrder, success: currySuccess(completion), failure: curryFailure(completion))
}
```
Looks like it replaces the order, but not the tag. This is different from what is happening when using obj-c APIs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the replaceTag entry point shown in the issue and compare its behavior with the Objective-C APIs. Trace how oldTag, newTag, and newTagOrder are passed, then verify that completing the operation changes the tag as well as its order.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c, swift
- Domain
- api, mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100