matrix-org / matrix-org/matrix-ios-sdk
Media loader: Make code use AFNetworking
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 484
- Forks
- 225
- PR merge metrics
- No merged PRs in 30d
Description
This often happens that users on an homeserver can post and see messages in the app but it cannot see media like in https://github.com/vector-im/riot-ios/issues/1803.
The reason is that the message (all matrix REST API) part uses AFNetworking, which does certs support for us and the media loading part, managed by our poor direct implementation at the top of NSURLConnection does not follow.
The media loader old code probably needs some refactoring. It comes from a c+p from pre-matrix projects with patches over patches.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the media loader and its direct NSURLConnection implementation; compare it with the AFNetworking path used for Matrix REST API requests. Confirm that media loading follows the same certificate handling and validate the affected behavior described in issue #1803.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- mobile-dev, networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100