matrix-org / matrix-org/matrix-ios-sdk

[MxRestClient] Update it to simplify category management

Open
#322 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
484
Forks
225
PR merge metrics
No merged PRs in 30d

Description

To add new client server requests, it is useful to create a category for MxClient.
In particulary, if you want to create a new loggin service or if you want to update access_token regularly and without needing to perform a logout/new loggin, some MxRestClient attributes should become public.
**Proposal:**
Add in MXRestClient.h a property for credentials
example: @property (nonatomic) MXCredentials *credentials
Following attributes should also become public
httpClient
identityHttpClient
processingQueue
completionQueue

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in MXRestClient.h and inspect the current declarations and visibility of MXCredentials, httpClient, identityHttpClient, processingQueue, and completionQueue. Done means the credentials property and listed attributes are publicly accessible for category-based client requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
objective-c
Domain
api, mobile
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.