matrix-org / matrix-org/matrix-ios-sdk
MXHTTPOperation: mutateTo must not be called if the original operation was cancelled
Open
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 484
- Forks
- 225
- PR merge metrics
- No merged PRs in 30d
Description
We need to check all the code.
The risk is that if the primary MXHTTPOperation has been cancelled, the second will be still processed and will call the success or failure block which is unexpected.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating MXHTTPOperation and trace its cancellation flow, including where a secondary operation can still be processed and invoke success or failure callbacks. Review all call sites that use mutateTo and add coverage showing that a secondary operation is not mutated after the original operation is cancelled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100