matrix-org / matrix-org/matrix-ios-sdk

MXFileStore: Aggregate commit operations

Open
#272 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
484
Forks
225
PR merge metrics
No merged PRs in 30d

Description

On an initialSync, there is a lot of data to store so that the 1st commit can take tens of seconds.
Each next commit will be queued and executed one by one once the 1st commit is done. Most of the time, these commits are small.

For performance, it would be interesting to aggregate these commits into a single commit operation in order to limit IO and thread switching.
More generally, we should apply this on coming commits where there is a commit that is processing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the MXFileStore commit path and the initialSync flow. Trace how commits are queued while one commit is processing, then determine how aggregation should preserve all pending writes while reducing IO and thread switching. Done means queued commits are combined appropriately during processing without data loss.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c
Domain
database, mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.