matrix-org / matrix-org/matrix-ios-sdk

Limit thread switching when handling http request response

Open
#201 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Objective-C
Stars
484
Forks
225
PR merge metrics
No merged PRs in 30d

Description

The current schema is:
AFNetworking thread => Main thread => MXRestClient processingQueue thread => Main thread

By using AFURLSessionManager.completionQueue, it could be:
AFNetworking thread => MXRestClient processingQueue thread => Main thread

If the sdk user defines a MXRestClient.completionQueue, it could even be:
AFNetworking thread => MXRestClient.completionQueue thread

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing MXRestClient's HTTP response handling and how AFURLSessionManager.completionQueue is configured. Compare the current queue sequence with the proposed sequences; done means unnecessary main-thread switching is removed and a user-defined MXRestClient.completionQueue is respected.

Written by the indexing model from the issue text.

Assessment

Tech stack
objective-c
Domain
mobile-dev, networking
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.