matrix-org / matrix-org/matrix-hookshot
Bridge should reject any invite that isn't for an admin room if the inviter doesn't have `manageConnections` permissions.
Open
Nobody has claimed this yet.
S-Minor
T-Defect
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
As otherwise the bridge will sit there gormless.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the bridge code that handles room invitations and the checks for admin rooms and manageConnections permissions. Confirm the expected behavior from issue 918: an inviter without manageConnections should have non-admin-room invites rejected; done when that behavior is covered by an appropriate test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authorization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100