matrix-org / matrix-org/matrix-hookshot
Reacting to a review of my PR on Matrix results in me reacting to my own PR on GitHub
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
I reacted with ❤️ to this message after Olivier kindly reviewed my PR. However, as my GitHub account is connected to hookshot (and was the one used to set up hookshot in this room), that translated into me reacting ❤️ to my own PR on GitHub. Which is hilarious, but unexpected.
I would perhaps expect this to happen if I had reacted to a "PR created" message, but not a "seperate person reviewed your PR" message. If anything, it should try and add a ❤️ to their PR review message (if it has one).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how Matrix reactions on GitHub review notifications are handled, using the reported review-message scenario as the reproduction case. Done means reacting to another person's review no longer adds a reaction to the reporter's own GitHub pull request, while the intended review-message behavior is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, typescript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100