matrix-org / matrix-org/matrix-hookshot

Hookshot does not understand Left Double Quotation Marks

Open
#839 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

Turns out Element X iOS types the wrong double quotes. Specifically [`“` - Left Double Quotation Mark (U+201C)](https://unicodeplus.com/U+201C) instead of the expected [`"` - Quotation Mark (U+0022)](https://unicodeplus.com/U+0022)

See https://github.com/vector-im/element-x-ios/issues/2060 for more details.

Hookshot does not understand “

```json
{
"content": {
"body": "!gl create “An issue using Left Double Quotation Marks“ “instead of normal Quotation Mark“",
"m.mentions": {},
"msgtype": "m.text"
},
"type": "m.room.message",
...
}
```

![Screenshot 2023-11-10 at 1 16 13 PM](https://github.com/matrix-org/matrix-hookshot/assets/19155609/e5731148-50ec-44dc-8d31-fce2c7b9d061)

![Screenshot 2023-11-10 at 1 19 05 PM](https://github.com/matrix-org/matrix-hookshot/assets/19155609/67a26112-4bec-4a76-a083-ef3c00df436f)

Contributor guide

Open the contributing guide

Research direction

Start with the JSON event example and trace how Hookshot parses the !gl command body. Check the related Element X iOS issue for the quotation-mark context. Done means the reproduced command using U+201C is understood correctly without breaking normal quotation marks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.