matrix-org / matrix-org/matrix-hookshot

Connection event type checkboxes are horrid and confusing

Open
#756 1 comment 0 reactions 0 assignees View on GitHub
GitHub S-Minor T-Defect Widgets / Provisioning
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

Currently, we have checkboxes like so in our widget:

![image](https://github.com/matrix-org/matrix-hookshot/assets/2072976/871cc3dc-2523-426e-ad24-4abf6e650de1)

The problem with these checkboxes, is that they are confusing and don't conform to what people would expect them to do.

- For instance, checking the top level "issues" checkbox will enable all issue events by adding the "issue" type to your allowed list.
- However, **disabling** it but leaving all the child items ticked will do the same thing.

I think generally it would be better to do away with the root checkbox items entirely, and instead move to a model where we just explicitly opt into each and every feature, rather than having parent and child event types.

Contributor guide

Open the contributing guide

Research direction

Start by locating the widget implementation for the connection event type checkboxes and the code that builds the allowed event-type list. Confirm how parent and child selections currently map to that list, then update the UI so each feature is opted into explicitly and verify that the resulting selections match the displayed checkboxes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.