matrix-org / matrix-org/matrix-hookshot

ES2022+ is unsupported

Open
#729 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

S-Tolerable T-Defect
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

We currently rely on behaviors such as:

```ts
class MyClass {
static aThing = "foo";
static collectionOfThings = [MyClass.aThing];
}
```

which was apparently fine in ES2021, but now throws an error about `TypeError: Cannot read properties of undefined`. We attempted to upgrade in #724 but it fell apart.

We need to determine if there is a TS compatibility setting we need to twiddle, or if we need to rewrite a bunch of assumptions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the failed upgrade attempt in issue #724 and the repository’s TypeScript compatibility settings. Reproduce the static-class-field example under the intended ES2022+ target, then determine whether configuration changes are sufficient or whether affected assumptions need rewriting. Done means the project supports the required ES2022+ behavior with the needed changes identified and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.