matrix-org / matrix-org/matrix-hookshot

Fix ts-node setup

Open
#722 0 comments 0 reactions 1 assignee View on GitHub

@AndrewFerr is already working on this.

Since Apr 21, 2023.

S-Minor T-Defect
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

Some of the yarn scripts that execute TypeScript files via ts-node fail with an error of "Emit skipped", because they target files that are outside of tsconfig.json's rootDir (as discussed here).

To fix this, TypeScript project settings must be changed so that the files run by ts-node are among those that get compiled into JS.

The most targeted way of achieving that is to add tsconfig overrides for ts-node: https://typestrong.org/ts-node/docs/configuration/#via-tsconfigjson-recommended

See: https://github.com/TypeStrong/ts-node/discussions/1595

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.