matrix-org / matrix-org/matrix-hookshot
Room actor `manageConnections` permission not working
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
Steps to reproduce:
- Create a room
- Set up `manageConnections` permissions with the room as actor
- With a user from that room
- Create another room
- Invite hookshot, make mod, create webhook
- Edit state and add transform function
Expected:
Allowed to do so
What happens:
Not allowed, hookshot resets the state event
```
ERROR 08:45:57:601 [ConnectionManager] User @test:example.com is disallowed to manage state for generic in !ASD:example.com
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ConnectionManager path indicated by the error and reproduce the permission setup and webhook state edit described in the issue. Trace why the room actor's manageConnections permission is rejected, then verify that the state event is no longer reset and the edit is allowed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100