matrix-org / matrix-org/matrix-hookshot
Generic hooks can still send very large events
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
```
INFO 22:19:05:561 [GenericHookConnection] onGenericHook !fibble:element.io
ERROR 22:19:05:605 [MatrixHttpClient] (REQ-12802) { errcode: 'M_TOO_LARGE', error: 'event too large' }
WARN 22:19:05:606 [Bridge] Failed to handle generic webhook Error: Failed to send Matrix message
at MessageSenderClient.sendMatrixMessage (/bin/matrix-hookshot/MatrixSender.js:91:15)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async GenericHookConnection.onGenericHook (/bin/matrix-hookshot/Connections/GenericHook.js:311:9)
at async /bin/matrix-hookshot/Bridge.js:369:25
at async Promise.all (index 0)
at async LocalMQ. (/bin/matrix-hookshot/Bridge.js:350:13)
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Connections/GenericHook.js:311 and /bin/matrix-hookshot/MatrixSender.js:91, using the reported M_TOO_LARGE failure as the reproduction point. Trace how a generic hook event is built and sent, then establish the intended handling for oversized events and add coverage showing that this failure is handled correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100