matrix-org / matrix-org/matrix-hookshot
What is the valid number range for priorities?
Open
Nobody has claimed this yet.
T-Defect
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
- Is
0a valid priority? - Are negative numbers a valid priority?
- Are floats a valid priority?
If 0 is a valid priority
This line needs to change from || to ??.
https://github.com/matrix-org/matrix-hookshot/blob/4dd4042c8b6adb7664ec14b44708280b29493835/src/Connections/GenericHook.ts#L217
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/Connections/GenericHook.ts at line 217 and inspect how priority is read. Determine whether 0, negative numbers, and floats are accepted, then update the conditional if required and record the resulting valid range.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100