matrix-org / matrix-org/matrix-hookshot
Empty admin rooms should be discarded or unused
@AndrewFerr is already working on this.
Since Nov 25, 2022.
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
If a user leaves their admin room, Hookshot continues to use it for posting URLs generated by !hookshot webhook. Since admin rooms are typically invite-only DMs, the user will never be able rejoin the room after leaving it, and will never be able to see those messages.
To prevent posting messages in inaccessible admin rooms, Hookshot should either leave empty admin rooms (on startup or in response to the user leaving), or should invite the user back to an admin room when posting a new message in it. My preference is the former, because it prevents Hookshot's room list from slowly growing larger and larger.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.