matrix-org / matrix-org/matrix-hookshot

Inconsistent casing in GitHub repo connection state keys

Open
#509 2 comments 0 reactions 1 assignee Claimed by @AndrewFerr View on GitHub
GitHub T-Defect
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

Using `!hookshot github repo ` lower-cases the repo's path when saving it as the room state key, but using the provisioning API does not.

This causes problems because room state keys are case-sensitive, meaning that adding a repo via the bot command vs the provisioning API will add that repo to the room twice.

Besides, a repo's URL path should never be lower-cased, as GitHub URLs / repo names are case-sensitive: https://docs.github.com/en/repositories/creating-and-managing-repositories/troubleshooting-cloning-errors#ensure-the-remote-is-correct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.