matrix-org / matrix-org/matrix-hookshot

`github list-connections` should linkify room IDs

Open
#371 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

T-Enhancement
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

currently:

https://github.com/matrix-org/matrix-hookshot/blob/86b9a83b9739fb3979dad25c13be4ac8ef917c49/src/AdminRoom.ts#L236

to build such a link, roughly do this (todo: check escaping of braces):

myhomeserver = # hookshot's homeserver, as it is joned to that room. i'm sure that variable exists somewhere
const roomLink = `https://matrix.to/#/${c.roomId}?via=${myhomeserver}`
const reposFormatted = connections.repos.map(c => ` - ${c.org}/${c.repo} (ID: \`${c.connectionId}\`, Room: [\`${c.roomId}\`]\(${roomLink}\))`).join('\n'); 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/AdminRoom.ts#L236, where the current output for github list-connections is assembled, and trace how the homeserver value is available. Update the room ID presentation so it produces the requested Matrix link, including checking the noted brace-escaping concern. Done means the command output links each room ID correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.