matrix-org / matrix-org/matrix-hookshot

Change `changes_requested` text to `requested changes`

Open
#363 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

GitHub T-Task Z-Good-First-Issue
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

The bot posts a message saying {user} changes_requested, but this doesn't flow well grammatically.

image

I feel like it'd be better if it said something like this:

image

I thought about removing in to fit in with other stuff the bot says, but the above made the most sense to me.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for the literal changes_requested and inspect the bot entry point that assembles this message. Update the displayed wording to requested changes, then run any relevant checks or tests you find for that message; done means the bot no longer posts the awkward original text.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.