matrix-org / matrix-org/matrix-hookshot
GitLabWatcher.getNotifications() doesn't seem to do anything
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
https://github.com/matrix-org/matrix-hookshot/blob/7ce1fd575347dda306f961b62ed0e4b9bf4b68b3/src/Notifications/GitLabWatcher.ts#L31-L34
What is this function doing?
It's declaring a variable but doesn't use or return it.
Is this a bug or are there side effects which should be documented?
Contributor guide
Research direction
Start with src/Notifications/GitLabWatcher.ts at lines 31-34 and inspect getNotifications() to determine what the declared variable is intended to do. Trace its callers and the surrounding GitLab notification flow; done means the behavior is corrected or its required side effects are clearly documented, with relevant tests updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100