matrix-org / matrix-org/matrix-hookshot
GitHub notification including images can not display images
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
Embedding an image in a github issue comment using markdown syntax  will be in the event body verbatim, and in the formatted_body as the appropriate <img> tag. However the latter isn't supported, as it isn't using an mxc:// url as src. The bridge would need to either upload the media, or instead just (deep)link it (convert <img src=XY> to <a href=XY>) which can either be clicked or shown with URL previews.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the GitHub comment bridge path that produces the event body and formatted_body, then inspect how Matrix message media URLs are handled. Confirm whether the intended fix is uploading the image or converting the img element to a link; done means GitHub image markdown no longer emits an unsupported non-mxc image source.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100