matrix-org / matrix-org/matrix-hookshot
GitHub notification includes HTML comments
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
includes html comments `` literally, these should get stripped.
on github: https://github.com/matrix-org/matrix-react-sdk/pull/5887#pullrequestreview-858005967
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the notification using the linked GitHub pull-request review, then trace the GitHub notification handling in the repository. Confirm where the literal HTML comment appears and identify the existing content-cleaning path. Done means the comment markers and their contents are absent from the Matrix notification while the remaining message is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100