matrix-org / matrix-org/matrix-hookshot
GitHub notification should state that a PR has been reviewed/review was commented
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
this is a PR review requesting changes, but you can't tell:
and a comment on the review:
also https://github.com/Half-Shot/matrix-hookshot/issues/29#issuecomment-1015775323 applies here
on github: https://github.com/matrix-org/matrix-react-sdk/pull/7584#pullrequestreview-857847150
this is an approving PR review:
on github: https://github.com/matrix-org/matrix-react-sdk/pull/5887#pullrequestreview-858005967
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the linked GitHub pull-request review examples and the notification behavior shown in the issue. Trace where GitHub review events become Matrix notifications, then ensure reviewed, change-requested, approving, and commented reviews are distinguishable in the resulting notification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, typescript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100