matrix-org / matrix-org/matrix-hookshot

GitHub notification quotes don't wrap the whole body

Open
#177 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

GitHub T-Defect Z-Good-First-Issue
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

![image](https://user-images.githubusercontent.com/2803622/149985165-2e4c9087-4f37-473c-a415-a3f4a916b89f.png)

for some reason, this is quoted doubly. the intended quote is closed after the first block instead of continuing the level 1 quote. original comment:

https://github.com/vector-im/element-web/issues/20578#issuecomment-1015574801

event source excerpt: `

\n
\n

I'm finding a difficulty in reproducing this issue, kindly helpsweat_smile

\n
\n
`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how GitHub notification bodies are converted from the event source HTML, using the linked Element issue and the nested blockquote excerpt to reproduce the behavior. The work is done when the full notification body remains inside the intended level-1 quote instead of ending after the first block.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.