matrix-org / matrix-org/matrix-hookshot

Support seperate webhook secrets for GitLab instances / repositories

Open
#145 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

GitLab T-Enhancement
Dominant language
TypeScript
Stars
450
Forks
95
Avg merge
1d 2h
Merged PRs (30d)
23

Description

https://github.com/Half-Shot/matrix-hookshot/blob/0c4b911a705f464d0a1edb51b2181845c4894b14/docs/setup/gitlab.md#L21

This isn't explained at all. I suspect you're supposed to enter it into this "Secret Token" field on GitLab?

![image](https://user-images.githubusercontent.com/2803622/148848957-c3912034-d4a5-489e-a727-63cbd76a3bb0.png)

Is it required? It would be nice if GitLab instanced could be user-defined, and also their secrets. If above assumption is correct, then the secret would also be shared across all instances, which isn't great.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with docs/setup/gitlab.md around line 21 and trace the GitLab webhook configuration it describes. Confirm how the Secret Token is currently interpreted, then scope per-instance and per-repository secrets and document when they are required. Done means the requested separation is supported and the setup guidance is unambiguous.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend-api-design, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.