matrix-org / matrix-org/matrix-hookshot
[feeds] honor charset
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 450
- Forks
- 95
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 23
Description
It seems that feeds always treats the rss feed as utf-8 encoded, even if both content-type and the xml header say different.
see https://rss.golem.de/rss.php?feed=RSS2.0 as an example:
```
< Server: nginx
< Date: Fri, 28 Nov 2025 14:44:39 GMT
< Content-Type: application/rss+xml; charset=ISO-8859-1
< Transfer-Encoding: chunked
< Connection: keep-alive
< Last-Modified: Fri, 28 Nov 2025 14:41:01 GMT
< ETag: RSS-f3fdc20cefd5a7bbd72804cbc30840e9
< Expires: Fri, 28 Nov 2025 14:46:39 GMT
< Content-Disposition: inline; filename=feed_full-RSS2.0.xml
```
Personally I would say: If no http header and inline xml encoding is specified, then use utf-8, else use the one specified inline, else the one of the http header
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the feeds handling entry point and reproduce the issue with the provided RSS URL. Trace how the HTTP Content-Type and XML declaration are read, then verify that the selected charset follows the stated precedence and that feeds with no charset still use UTF-8.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100